[CIR][NFC] move data member pointer lowering to CXXABI #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang/lib/CIR/Dialect/Transforms/TargetLowering/ItaniumCXXABI.cpp
Outdated
Show resolved
Hide resolved
| // the class object containing it, represented as a ptrdiff_t | ||
| const clang::TargetInfo &target = LM.getTarget(); | ||
| unsigned width = | ||
| target.getTypeWidth(target.getPtrDiffType(clang::LangAS::Default)); |
There was a problem hiding this comment.
sounds like this method should be about returning width instead? Answering LLVM type questions at this point sounds like layer violation?
Lancern
force-pushed
the
data-member-lowering
branch
2 times, most recently
from
a564ce0 to
02e6c13
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Lancern
force-pushed
the
data-member-lowering
branch
from
02e6c13 to
cc18fbf
Compare
|
Fixed format issues and rebased. |
Lancern
force-pushed
the
data-member-lowering
branch
from
cc18fbf to
9529507
Compare
Lancern
force-pushed
the
data-member-lowering
branch
from
9529507 to
94f8d28
Compare
This patch moves the lowering code for data member pointers from the conversion patterns to the implementation of CXXABI because this part should be ABI- specific.
Lancern
force-pushed
the
data-member-lowering
branch
from
94f8d28 to
e984e58
Compare
bcardosolopes
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the lowering code for data member pointers from the conversion patterns to the implementation of CXXABI because this part should be ABI-specific.